From 2188e62d4b5da6c25ca489a89d3e12427b028320 Mon Sep 17 00:00:00 2001
From: Golumpa <Golumpa@users.noreply.github.com>
Date: Tue, 23 Jun 2026 15:14:20 +0100
Subject: [PATCH] update release workflow to catch forgotten version bumping

I forgot to bump the version to 0.1.8 in the last release but my workflows still ran and replaced the 0.1.7 files. Added a validation check and now refuses to release on an existing tag.
---
 .github/workflows/release.yml | 46 +++++++++++++++++++++++++++++++----
 1 file changed, 41 insertions(+), 5 deletions(-)

diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
index 7f9d2b1..c995162 100644
--- a/.github/workflows/release.yml
+++ b/.github/workflows/release.yml
@@ -7,9 +7,38 @@ permissions:
   contents: write
 
 jobs:
+  validate-release:
+    name: Validate Release
+    if: github.ref == 'refs/heads/main'
+    runs-on: ubuntu-latest
+
+    steps:
+      - name: Checkout Source Code
+        uses: actions/checkout@v5
+        with:
+          fetch-depth: 0
+
+      - name: Check release tag is new
+        env:
+          GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+        run: |
+          version="$(python -c "import tomllib; print(tomllib.load(open('pyproject.toml', 'rb'))['project']['version'])")"
+          tag="v${version}"
+
+          if git rev-parse -q --verify "refs/tags/${tag}" >/dev/null; then
+            echo "::error title=Release tag already exists::${tag} already exists. Bump project.version in pyproject.toml before running the release workflow."
+            exit 1
+          fi
+
+          if gh release view "$tag" >/dev/null 2>&1; then
+            echo "::error title=GitHub release already exists::${tag} already has a GitHub release. Bump project.version in pyproject.toml before running the release workflow."
+            exit 1
+          fi
+
   build-windows:
     name: Build Windows
     if: github.ref == 'refs/heads/main'
+    needs: validate-release
     runs-on: windows-latest
 
     steps:
@@ -44,6 +73,7 @@ jobs:
   build-linux:
     name: Build Linux
     if: github.ref == 'refs/heads/main'
+    needs: validate-release
     runs-on: ubuntu-latest
 
     steps:
@@ -81,6 +111,7 @@ jobs:
   build-macos:
     name: Build Macos
     if: github.ref == 'refs/heads/main'
+    needs: validate-release
     runs-on: macos-15-intel
 
     steps:
@@ -195,9 +226,14 @@ jobs:
             nte-history-exporter-v${version}-x86_64-apple-darwin.zip
           )
 
-          if gh release view "$tag" >/dev/null 2>&1; then
-            gh release edit "$tag" --notes-file release-notes.md
-            gh release upload "$tag" "${files[@]}" --clobber
-          else
-            gh release create "$tag" "${files[@]}" --title "${tag} Release" --notes-file release-notes.md
+          if git rev-parse -q --verify "refs/tags/${tag}" >/dev/null; then
+            echo "::error title=Release tag already exists::${tag} already exists. Bump project.version in pyproject.toml before running the release workflow."
+            exit 1
           fi
+
+          if gh release view "$tag" >/dev/null 2>&1; then
+            echo "::error title=GitHub release already exists::${tag} already has a GitHub release. Bump project.version in pyproject.toml before running the release workflow."
+            exit 1
+          fi
+
+          gh release create "$tag" "${files[@]}" --title "${tag} Release" --notes-file release-notes.md